Allow reordering terminal tabs via drag and drop#2681
Open
vogella wants to merge 1 commit into
Open
Conversation
Contributor
Contributor
Author
|
Needs the change in SWT, which should be available tomorrow, after that this can be tested. |
vogella
force-pushed
the
feature/terminal-tab-reorder-2679
branch
from
e6aed94 to
9d4e6d6
Compare
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
vogella
force-pushed
the
feature/terminal-tab-reorder-2679
branch
2 times, most recently
from
ae440dd to
0957a61
Compare
Dragging a terminal tab within the same Terminals view now reorders it to the drop position, matching the drag-to-reorder behavior of editor and view tabs. The drop within the same view was previously rejected. The reorder uses the new CTabFolder.moveItem(int, int) API, so the live terminal control stays attached and no longer has to be recreated. The existing cross-view move (which transfers a terminal to a different Terminals view) is unchanged, as it still requires re-parenting. Requires SWT 3.135. Fixes eclipse-platform#2679
vogella
force-pushed
the
feature/terminal-tab-reorder-2679
branch
from
0957a61 to
df4c5bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging a terminal tab within the same Terminals view now reorders it to the drop position, the same way editor and view tabs can be rearranged.
Previously a drop inside the originating view was rejected, so tabs could only be moved to a different Terminals view.
The reorder relies on the new
CTabFolder.moveItem(int, int)API (SWT 3.135, eclipse-platform/eclipse.platform.swt#3350), which keeps the live terminal control attached instead of recreating it.The existing cross-view move is left untouched because transferring a terminal to a different view still requires re-parenting.
Draft because it depends on SWT 3.135, which is not yet in the platform target platform, so CI cannot build it until that lands.
Fixes #2679